fix(ui5-carousel): add aria-label to the list element #12587
Conversation
|
🧹 Preview deployment cleaned up: https://pr-12587--ui5-webcomponents.netlify.app |
| #XACT: ARIA announcement for the attribute 'aria-roledescription' of the Carousel component | ||
| CAROUSEL_ARIA_ROLE_DESCRIPTION=Carousel | ||
|
|
||
| #XACT: ARIA announcement for aria label attribute of Carousel element with list role |
There was a problem hiding this comment.
Please consider:
XACT: ARIA announcement for the aria-label attribute of the Carousel component with role='list'
In the above ARIA announcement, it's referred to as "component", thus for consistency, please keep it identical in both announcements.
There was a problem hiding this comment.
changed to ARIA announcement for the aria-label attribute of an element within a Carousel component with a list role as the list element is inside the component
GerganaKremenska
left a comment
GerganaKremenska
left a comment
There was a problem hiding this comment.
Maybe change commit massage to: fix(ui5-carousel): add aria-label to the list element
TeodorTaushanov
changed the title
|
🎉 This PR is included in version v2.16.0 🎉 The release is available on v2.16.0 Your semantic-release bot 📦🚀 |
No description provided.