Skip to content

fix(ui5-carousel): add aria-label to the list element #12587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2025
Merged

fix(ui5-carousel): add aria-label to the list element #12587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3c2cf9
fix(ui5-carousel): add correct aria-label to the list element
TeodorTaushanov Oct 30, 2025
2f0d39e
Merge remote-tracking branch 'origin/main' into carousel_acc
TeodorTaushanov Nov 3, 2025
82755fd
chore: adress code comments
TeodorTaushanov Nov 3, 2025
be068da
Merge remote-tracking branch 'origin/main' into carousel_acc
TeodorTaushanov Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/main/cypress/specs/Carousel.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,11 @@ describe("Carousel general interaction", () => {
.find(".ui5-carousel-content")
.should("have.attr", "role", "list");

cy.get("#carousel5")
.shadow()
.find(".ui5-carousel-content")
.should("have.attr", "aria-label", "Item Container");

cy.get("#carousel5")
.shadow()
.find(".ui5-carousel-item")
Expand Down
5 changes: 5 additions & 0 deletions packages/main/src/Carousel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import {
CAROUSEL_PREVIOUS_ARROW_TEXT,
CAROUSEL_NEXT_ARROW_TEXT,
CAROUSEL_ARIA_ROLE_DESCRIPTION,
CAROUSEL_ARIA_LIST_LABEL,
} from "./generated/i18n/i18n-defaults.js";
import CarouselArrowsPlacement from "./types/CarouselArrowsPlacement.js";
import CarouselPageIndicatorType from "./types/CarouselPageIndicatorType.js";
Expand Down Expand Up @@ -977,6 +978,10 @@ class Carousel extends UI5Element {
return Carousel.i18nBundle.getText(CAROUSEL_ARIA_ROLE_DESCRIPTION);
}

get _ariaListLabel() {
return Carousel.i18nBundle.getText(CAROUSEL_ARIA_LIST_LABEL);
}

/**
* Returns only visible (non-hidden) content items.
* Items with the 'hidden' attribute are automatically excluded from carousel navigation.
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/CarouselTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default function CarouselTemplate(this: Carousel) {
onMouseDown={this._onmousedown}
>
<div class={this.classes.viewport} part="content">
<div role="list" class={this.classes.content} style={{ transform: `translate3d(${this._isRTL ? "" : "-"}${this._currentSlideIndex * (this._itemWidth || 0)}px, 0, 0` }}>
<div role="list" aria-label={this._ariaListLabel} class={this.classes.content} style={{ transform: `translate3d(${this._isRTL ? "" : "-"}${this._currentSlideIndex * (this._itemWidth || 0)}px, 0, 0` }}>
{this.items.map(itemInfo =>
<div
data-sap-focus-ref
Expand Down
3 changes: 3 additions & 0 deletions packages/main/src/i18n/messagebundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ CAROUSEL_NEXT_ARROW_TEXT=Next Page
#XACT: ARIA announcement for the attribute 'aria-roledescription' of the Carousel component
CAROUSEL_ARIA_ROLE_DESCRIPTION=Carousel

#XACT: ARIA announcement for the aria-label attribute of an element within a Carousel component with a list role
CAROUSEL_ARIA_LIST_LABEL=Item Container

#XFLD: Label of the container holding the colors
COLORPALETTE_CONTAINER_LABEL=Color palette - Predefined colors

Expand Down
Loading