Skip to content

Conversation

@kgogov
Copy link
Contributor

@kgogov kgogov commented Nov 6, 2025

Update message bundle to use "Collapse Header" instead of "Snap Header" for better UX consistency.

Fixes #12617

Update message bundle to use "Collapse Header" instead of
"Snap Header" for better UX consistency.

Fixes #12617
@NakataCode NakataCode self-requested a review November 6, 2025 13:04
Copy link
Contributor

@NakataCode NakataCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little Suggestion

The tooltip text has been updated from "Snap Header" to "Collapse Header" for UX consistency, but the JSDoc comments in DynamicPage.ts still reference the old terminology:

Line 75:

If focus is on the snap header button (arrow button), or on the header itself, once activated, it triggers the associated action (such as snap/expand the header).

Suggestion: Update this to:

If focus is on the collapse header button (arrow button), or on the header itself, once activated, it triggers the associated action (such as collapse/expand the header).

This would make the documentation consistent with the user-facing tooltip text change.

@kgogov
Copy link
Contributor Author

kgogov commented Nov 6, 2025

A little Suggestion

The tooltip text has been updated from "Snap Header" to "Collapse Header" for UX consistency, but the JSDoc comments in DynamicPage.ts still reference the old terminology:

Line 75:

If focus is on the snap header button (arrow button), or on the header itself, once activated, it triggers the associated action (such as snap/expand the header).

Suggestion: Update this to:

If focus is on the collapse header button (arrow button), or on the header itself, once activated, it triggers the associated action (such as collapse/expand the header).

This would make the documentation consistent with the user-facing tooltip text change.

Thanks for the suggestion! I was also considering changing the terminology from "snap" to "collapse" everywhere, including variable names. Honestly, in this specific case, it’s not strictly necessary since the SAPUI5 DynamicPage documentation still uses the term "snap". The change here is mainly for the tooltip text to improve UX clarity — the actual behavior remains the same; we’re just using a synonym for "snap".

@kgogov kgogov requested a review from NakataCode November 6, 2025 14:39
@kgogov kgogov merged commit 4cf0976 into main Nov 6, 2025
19 of 20 checks passed
@kgogov kgogov deleted the dynamic-page-tooltip-text-update branch November 6, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DynamicPage: Inconsistent Tooltip Text Across Pages ("Collapse Header" vs "Snap Header"

3 participants