Skip to content

fix(ui5-dynamic-page): update header action button tooltip text #12634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

fix(ui5-dynamic-page): update header action button tooltip text #12634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4af7fe9
fix(ui5-dynamic-page): update header action button tooltip text
kgogov Nov 6, 2025
5261e64
fix(ui5-dynamic-page): fix failing tests due to tooltip text update
kgogov Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/fiori/cypress/specs/DynamicPage.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,8 +957,8 @@ describe("ARIA attributes", () => {
.find("[ui5-dynamic-page-header-actions]")
.shadow()
.find("[ui5-button].ui5-dynamic-page-header-action-expand")
.should("have.prop", "accessibleName", "Snap Header")
.should("have.prop", "tooltip", "Snap Header");
.should("have.prop", "accessibleName", "Collapse Header")
.should("have.prop", "tooltip", "Collapse Header");

cy.get("[ui5-dynamic-page]")
.shadow()
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/src/i18n/messagebundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ DYNAMIC_PAGE_ARIA_LABEL_SNAPPED_HEADER=Header Snapped
DYNAMIC_PAGE_ARIA_LABEL_EXPAND_HEADER=Expand Header

#XACT: Aria label for the button that snaps the header
DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Snap Header
DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Collapse Header

#XACT: Aria label for the button that pins the header
DYNAMIC_PAGE_ARIA_LABEL_PIN_HEADER=Pin Header
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/src/i18n/messagebundle_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ DYNAMIC_PAGE_ARIA_LABEL_SNAPPED_HEADER=Header Snapped

DYNAMIC_PAGE_ARIA_LABEL_EXPAND_HEADER=Expand Header

DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Snap Header
DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Collapse Header

DYNAMIC_PAGE_ARIA_LABEL_PIN_HEADER=Pin Header

Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/src/i18n/messagebundle_en_GB.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ DYNAMIC_PAGE_ARIA_LABEL_SNAPPED_HEADER=Header Snapped

DYNAMIC_PAGE_ARIA_LABEL_EXPAND_HEADER=Expand Header

DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Snap Header
DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Collapse Header

DYNAMIC_PAGE_ARIA_LABEL_PIN_HEADER=Pin Header

Expand Down
Loading