fix(ui5-timeline, ui5-view-settings-dialog): correct parameters definition#12915
Merged
fix(ui5-timeline, ui5-view-settings-dialog): correct parameters definition#12915
Conversation
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12915--ui5-webcomponents.netlify.app |
tsanislavgatev
previously approved these changes
Jan 16, 2026
Contributor
Author
|
There are few minor known visual discrepancies (not easily fixable), not introduced by the change. |
tsanislavgatev
approved these changes
Jan 19, 2026
Collaborator
|
🎉 This PR is included in version v2.19.0-rc.2 🎉 The release is available on v2.19.0-rc.2 Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version v2.19.0-rc.2 🎉 The release is available on v2.19.0-rc.2 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously few of our Cozy and Compact parameters for Timeline-related and ViewSettingsDialog components were defined in the wrong package
sizes-parameters.cssfile. This could cause potential framework level issues.We now moved those definitions to the correct places.
We're still monitoring for any noticeable visual changes. So misalignments might occur in the current state.