Skip to content

feat(ui5-search): update visual hover and active state of shell search scope#13256

Merged
Vonahz merged 8 commits into
mainfrom
search_activehover
May 22, 2026
Merged

feat(ui5-search): update visual hover and active state of shell search scope#13256
Vonahz merged 8 commits into
mainfrom
search_activehover

Conversation

@Vonahz
Copy link
Copy Markdown
Contributor

@Vonahz Vonahz commented Mar 11, 2026

JIRA: BGSOFUIRILA-4275

@Vonahz Vonahz requested a review from niyap March 11, 2026 14:19
@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

ui5-webcomponents-bot commented Mar 11, 2026

🧹 Preview deployment cleaned up: https://pr-13256--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 11, 2026 14:27 Inactive
Copy link
Copy Markdown
Contributor

@niyap niyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When select is active, it is expected to have a border, which is currently no presented
  2. Please, ask about the expected behaviour when search is active and hovered. Currently, it looks really strange. If the picker is open and the mouse cursor is somewhere within the picker or the search field, it receives hover styles (grey border, previously is was blue). Also, when it is open, please hover over its button -> its get bigger and color is changed

Comment thread packages/fiori/src/themes/sap_horizon_hcb/SearchField-parameters.css Outdated
Comment thread packages/fiori/src/themes/SearchField.css
Comment thread packages/fiori/src/themes/SearchField.css Outdated
Comment thread packages/fiori/src/themes/SearchField.css
Comment thread packages/fiori/src/themes/SearchField.css
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 12, 2026 12:56 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 12, 2026 13:22 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 12, 2026 15:04 Inactive
@github-actions github-actions Bot added the Stale label Mar 27, 2026
@github-actions github-actions Bot closed this Apr 4, 2026
@Vonahz Vonahz reopened this May 18, 2026
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 18, 2026 12:28 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 18, 2026 12:30 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 18, 2026 15:07 Inactive
@ivoplashkov ivoplashkov requested a review from MapTo0 May 20, 2026 07:35
@Vonahz Vonahz merged commit 73a4a8b into main May 22, 2026
13 checks passed
@Vonahz Vonahz deleted the search_activehover branch May 22, 2026 11:40
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 22, 2026 11:40 Inactive
@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version v2.23.0-rc.0 🎉

The release is available on v2.23.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants