feat(ui5-menu): menu item groups with checkable menu items #10028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinzzx
requested changes
Oct 17, 2024
nnaydenow
previously requested changes
Oct 22, 2024
nnaydenow
dismissed
their stale review
Menu tests are fixed and this PR no longer need to be blocked
hinzzx
approved these changes
Oct 25, 2024
tsanislavgatev
requested changes
Oct 29, 2024
hinzzx
reviewed
Oct 29, 2024
tsanislavgatev
requested changes
Nov 7, 2024
nnaydenow
previously requested changes
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Jun 10, 2025
ilhan007
reviewed
Jun 10, 2025
ilhan007
reviewed
Jun 10, 2025
ilhan007
requested changes
Jun 10, 2025
ilhan007
reviewed
Jun 10, 2025
ilhan007
reviewed
Jun 10, 2025
nnaydenow
reviewed
Jun 11, 2025
adrian-bobev
previously requested changes
Jun 17, 2025
ilhan007
approved these changes
Jun 20, 2025
NHristov-sap
dismissed stale reviews from vladitasev, adrian-bobev, and nnaydenow
We agreed the PR is good to go
1 task
NHristov-sap
added a commit
that referenced
this pull request
Jun 26, 2025
…nge' event (#11793) There were 2 events introduced in PR #10028 - private `item-check` event fired by `MenuItem` when its `checked` property changes, and public `check-change` event fired by `MenuItemGroup` when any of its `MenuItem` components changes it's `checked` property. This PR removes these two events in favor of single public `check` event, fired by the `MenuItem` when its `checked` property changes. The new situation will be more suitable for handling `MenuItem` `checked` states and updating models in applications that use Menu Item Groups.
Collaborator
|
🎉 This PR is included in version v2.12.0-rc.2 🎉 The release is available on v2.12.0-rc.2 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces MenuItemGroup component that can hold regular MenuItem components. The MenuItemGroup has a property named
itemCheckModewhich can have values amongNone(default),SingleandMultiple. MenuItemGroup can be slotted in a Menu or MenuItem default slot as any other regular MenuItem. Nesting of MenuItemGroup components is not allowed, but any Menu or MenuItem can contain more than one MenuItemGroup components with differentitemCheckModesettings.When
itemCheckModeis:None, the Menu acts exactly like until now.Singlemeans that zero or one MenuItems can be checked at a time.Multiplemeans that zero or many MenuItems can be checked at a time.There is also new property
checkedintroduced in MenuItem. By setting it the item is marked as checked and this is visualized as checkmark at the end of the item. This property is taken into account only when the corresponding item is a member of MenuItemGroup withSingleorMultiplevalue ofitemCheckMode.It is recommended to place separators before and after each MenuItemGroup, but this is not mandatory and depends on the application developers.