Skip to content

fix(ui5-select): add support for Vue.js v-model #10149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix(ui5-select): add support for Vue.js v-model #10149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/main/src/Select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,15 @@ type SelectLiveChangeEventDetail = {
@event("selected-item-changed", {
bubbles: true,
})

/**
* Fired to make Vue.js two way data binding work properly.
* @private
*/
@event("input", {
bubbles: true,
})

class Select extends UI5Element implements IFormInputElement {
@i18n("@ui5/webcomponents")
static i18nBundle: I18nBundle;
Expand Down Expand Up @@ -749,6 +758,9 @@ class Select extends UI5Element implements IFormInputElement {
// Angular two way data binding
this.fireDecoratorEvent("selected-item-changed");

// Fire input event for Vue.js two-way binding
this.fireDecoratorEvent("input");

if (changePrevented) {
this._select(this._selectedIndexBeforeOpen);
}
Expand Down