chore: warn when scoping suffix is set too late #10781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
approved these changes
Feb 6, 2025
dobromiraboycheva
added a commit
that referenced
this pull request
Feb 11, 2025
…ui5-settings * 'main' of https://github.com/SAP/ui5-webcomponents: refactor(ui5-multi-combobox): switch to .tsx (#10807) refactor(ListItem): delete unused code (#10796) chore(deps-dev): bump esbuild from 0.19.9 to 0.25.0 (#10816) chore(deps-dev): bump vitest from 3.0.2 to 3.0.5 (#10785) test: add command for single cy test run (#10813) docs: fix TimelineGrowingMode enum docs (#10815) fix(ui5-side-navigation): remove inappropriate exclamation mark usage (#10769) feat(ui5-link): introduce reactive area size property (#10762) fix(ui5-side-navigation): "Space" key triggers links (#10767) chore(ui5-timeline): importing a timeline group item in the samples (#10793) chore: add ElementInternals shim (#10782) chore: fix MultiInput test (#10791) Translation Delivery (#10772) chore(ui5-select): remove unused css vars (#10789) chore: warn when scoping suffix is set too late (#10781) fix(ui5-button): remove tap highlight on safari (#10786) feat(ui5-table): action header cell is added (#10698) docs: fix List sample chore(release): publish v2.8.0-rc.0 [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address wrong use of scoping, which happens more often recently, we log a warning when scoping is set after any tag definition. Because for scoping to work, it must be set and known before custom elements definitions.
Fixes: #10771