Skip to content

fix(ui5-time-picker): Add interactive mode for the icon on mobile devices #12500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

fix(ui5-time-picker): Add interactive mode for the icon on mobile devices #12500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/main/src/TimePicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
} from "@ui5/webcomponents-base/dist/util/AccessibilityTextsHelper.js";
import "@ui5/webcomponents-localization/dist/features/calendar/Gregorian.js"; // default calendar for bundling
import DateFormat from "@ui5/webcomponents-localization/dist/DateFormat.js";
import IconMode from "./types/IconMode.js";
import getCachedLocaleDataInstance from "@ui5/webcomponents-localization/dist/getCachedLocaleDataInstance.js";
import {
isShow,
Expand Down Expand Up @@ -458,6 +459,14 @@ class TimePicker extends UI5Element implements IFormInputElement {
return this.hasValueStateText && !this._inputsPopover?.open;
}

/**
* Defines whether the value help icon is hidden
* @private
*/
get _iconMode() {
return isDesktop() ? IconMode.Decorative : IconMode.Interactive;
}

onTimeSelectionChange(e: CustomEvent<TimeSelectionChangeEventDetail>) {
this.tempValue = e.detail.value; // every time the user changes the time selection -> update tempValue
}
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/TimePickerTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export default function TimePickerTemplate(this: TimePicker) {
name={timeEntryRequest}
tabindex={-1}
showTooltip={true}
mode={this._iconMode}
onClick={this._togglePicker}
class={{
"ui5-time-picker-input-icon-button": true,
Expand Down
Loading