fix(ui5-color-palette-item): remove inline styles #12558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12558--ui5-webcomponents.netlify.app |
hinzzx
previously requested changes
Oct 30, 2025
| const itemHeight = this.offsetHeight + 4; // adding 4px for the offsets on top and bottom | ||
| this.style.setProperty(getScopedVarName("--_ui5_color_palette_item_height"), `${itemHeight}px`); | ||
|
|
||
| this.style.setProperty(getScopedVarName("--_ui5-color-palette-item-background-color"), `${this.value}`); |
Contributor
There was a problem hiding this comment.
Are we sure we address the CSP Violation ? Even though right now it sets scoped-variable, malicious link still could be inserted through it. Maybe some sort of sanitization would work ?
Contributor
There was a problem hiding this comment.
as discussed offline, we'll go for it as it is for now. If any concerns arise, we'll investigate it further.
hinzzx
dismissed
their stale review
discussed offline, that we're going for that approach for the moment.
hinzzx
approved these changes
Oct 30, 2025
Collaborator
|
🎉 This PR is included in version v2.16.0 🎉 The release is available on v2.16.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #12550