fix(ui5-switch): fix focus border position #2319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MapTo0
approved these changes
Oct 8, 2020
ilhan007
pushed a commit
that referenced
this pull request
Oct 17, 2020
This change fixes the wrong focus border position.It's 2px more from the right side because the border itself is not considered.
ilhan007
pushed a commit
that referenced
this pull request
Nov 11, 2020
This change fixes the wrong focus border position.It's 2px more from the right side because the border itself is not considered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the wrong focus border position:
It's 2px more from the right side because the border itself is not considered.
Alternative solution would be:
But using
width=100%with absolutely positioned elements in general is not a best practice.