Skip to content

fix(ui5-list): remove busy indicator DOM #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2021
Merged

fix(ui5-list): remove busy indicator DOM #2712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/main/src/List.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@
{{/if}}
</div>

<div class="ui5-list-busy-row">
<ui5-busyindicator ?active="{{busy}}" size="Medium" class="ui5-list-busy-ind"></ui5-busyindicator>
</div>
{{#if busy}}
<div class="ui5-list-busy-row">
<ui5-busyindicator active size="Medium" class="ui5-list-busy-ind"></ui5-busyindicator>
</div>
{{/if}}
</div>
6 changes: 4 additions & 2 deletions packages/main/test/specs/List.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ describe("List Tests", () => {
});

it("List is rendered", () => {
const list = browser.$("ui5-list").shadow$(".ui5-list-root");
const list = browser.$("#infiniteScrollEx").shadow$(".ui5-list-root");
const busyInd = browser.$("#infiniteScrollEx").shadow$(".ui5-list-busy-row");

assert.ok(list, "List is rendered");
assert.ok(list.isExisting(), "List is rendered");
assert.notOk(busyInd.isExisting(), "Busy indicator is not rendered, when List is not busy");
});

it("itemPress and selectionChange events are fired in Single selection", () => {
Expand Down