Skip to content

share venv with other users #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JinIgarashi merged 4 commits into from
Dec 19, 2024
Merged

share venv with other users #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60f98f8
share venv with other users
JinIgarashi Dec 19, 2024
328baae
fix: ci
JinIgarashi Dec 19, 2024
66c94e0
fix: ci
JinIgarashi Dec 19, 2024
735146c
fix: ci
JinIgarashi Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ jobs:
mkdir -p "$CACHE_DIR"
docker save ${{ steps.image_tag.outputs.TAG }} > ${{ steps.image_tag.outputs.TAR_PATH }}

- name: Install dependencies in container
run: |
docker run --rm -v ${{ github.workspace }}:/app -w /app --entrypoint /bin/bash ${{ steps.image_tag.outputs.TAG }} -c "
export LANG=C.UTF-8 && pipenv install -e .
"
- name: Run tests in container
run: |
# Change owner of workspace to ubuntu user
Expand Down
5 changes: 4 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ RUN chmod +x /app/create_user.sh
RUN chmod +x /app/entrypoint.sh

# install package
RUN pipenv --python 3 && pipenv run pip install -e .
ENV PIPENV_VENV_IN_PROJECT=1
RUN pipenv install --dev --python 3 && \
pipenv run pip install -e .
ENV VIRTUAL_ENV=/app/.venv

EXPOSE 22

Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ The below command is connecting to `localhost` with user `docker` through port `
```shell
ssh docker@localhost -p 2222

# make sure installing the package first
cd /app
pipenv run pip install -e .
# it will automatically enter venv in /app folder
# then run rapida command
rapida --help
```

### destroy docker container
Expand Down
7 changes: 3 additions & 4 deletions create_user.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ else
# Grant sudo access (optional)
usermod -aG sudo "$USERNAME"
echo "User $USERNAME granted sudo privileges."
fi

# Set ownership of /app folder to the user
chown -R "$USERNAME:$USERNAME" /app
echo "Ownership of /app granted to $USERNAME."
echo "cd /app; pipenv shell;" >> /home/$USERNAME/.bashrc
echo "User $USERNAME profile was modified to launch venv in starting."
fi
Loading