Skip to content

Conversation

@lparsons
Copy link
Member

@lparsons lparsons commented Feb 13, 2025

Description

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

@lparsons lparsons force-pushed the bhm-2025-discussion branch from d512386 to e939de7 Compare February 13, 2025 23:12
@lparsons lparsons marked this pull request as ready for review February 13, 2025 23:15
Copy link
Member

@exoticDFT exoticDFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only one comment would be it may make sense to include the time with the date in the paragraph section. Although it's at the top with the add to calendar button, it still might be worth mentioning below as well.

@lparsons
Copy link
Member Author

lparsons commented Feb 14, 2025

Good call, it's been added.

Preview link: https://output.circle-artifacts.com/output/job/57e4d9fd-b1f8-4a1a-a50a-914c62d58bf5/artifacts/0/usrse.github.io/events/2025/2025-02-bhm-discussion/index.html

@USRSE/usrse-maintainers This is ready for merging. The URL check failures seem temporary to me.

edit: needed a rebase, should all be good but checks are re-running).
edit 2: rebased and checks complete, new URL failure, also temporary (works for me in the browser)

@lparsons lparsons force-pushed the bhm-2025-discussion branch from f6ab9cd to eaba2a5 Compare February 14, 2025 18:26
@crd477 crd477 merged commit 22f1780 into USRSE:main Feb 14, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants