-
Notifications
You must be signed in to change notification settings - Fork 0
dev/add support for trace #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gausshj
wants to merge
4
commits into
main
Choose a base branch
from
dev/add-support-for-trace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
156b5d0
test(matmul): add assertion tests for matmul of impure tensors
gausshj 520984c
feat(trace): add trace support for tensor
gausshj babaef3
Revert "test(matmul): add assertion tests for matmul of impure tensors"
gausshj 8d23116
dev(trace): remove unnecessary judge
gausshj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import torch | ||
from grassmann_tensor.tensor import GrassmannTensor | ||
|
||
|
||
def test_trace() -> None: | ||
gt = GrassmannTensor( | ||
(False, False, False), | ||
((1, 1), (1, 1), (1, 1)), | ||
torch.tensor([[[1, 0], [0, 2]], [[0, 3], [4, 0]]]), | ||
) | ||
gt.trace((0, 1)) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议你新实现一个只支持对最后两个指标进行trace的版本
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不然你对符号的处理完全不对,最后两个指标trace的时候,T F的话,不需要加任何符号,F T的话,需要根据最后两个指标的parity加符号(2个相互trace的指标的parity应该是完全一致的)。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那能否通过permute来实现,将需要trace的指标移到最后,然后再按照当前的代码逻辑来求trace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,确实是应该这么干的,先实现下最后两个指标的,然后外面套个permute。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
只要你能把两个指标的trace写对,后面套permute很难写错,所以建议你先把两个指标的版本写对。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你现在的符号没处理对啊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不是没处理对符号,是没处理符号=_=、、、你只需要permute成T F的话,符号才可以恰好不用处理。