-
Notifications
You must be signed in to change notification settings - Fork 12
updating homework #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating homework #10
Conversation
self.output_dict = {} | ||
|
||
def return_as_dictionary(self): | ||
""""can I get rid of the replicated ones from the original class?""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you?
|
||
|
||
def main_menu(user_prompt=None): | ||
""""This method is the menu for the program. The intent is to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like your comments
|
||
|
||
class InventoryTest(unittest.TestCase): | ||
"""Tests for inventory_class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this
class FurnitureTest(unittest.TestCase): | ||
"""Tests for furniture_class | ||
1. can take 6 input items and create a dictionary""" | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is purpose of this?
# # Date: 4/17/2019 | ||
# # ChangeLog: (Who, What) | ||
# Justin Jameson | ||
# correct ouput to output line 20 'ouptu JSON file' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
logging.debug('made it through value total_days') | ||
value['total_price'] = value['total_days'] * value['price_per_day'] | ||
logging.debug('made it through total_price') | ||
# value['sqrt_total_price'] = math.sqrt(value['total_price']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think how you could log particular errors that could happen (e.g., missing field, end date smaller than beginning date...) and what would be severity of these log messages.
updated homework