Skip to content

Conversation

jjame369
Copy link
Contributor

updated homework

self.output_dict = {}

def return_as_dictionary(self):
""""can I get rid of the replicated ones from the original class?"""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you?



def main_menu(user_prompt=None):
""""This method is the menu for the program. The intent is to

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like your comments



class InventoryTest(unittest.TestCase):
"""Tests for inventory_class

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

class FurnitureTest(unittest.TestCase):
"""Tests for furniture_class
1. can take 6 input items and create a dictionary"""
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is purpose of this?

# # Date: 4/17/2019
# # ChangeLog: (Who, What)
# Justin Jameson
# correct ouput to output line 20 'ouptu JSON file'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

logging.debug('made it through value total_days')
value['total_price'] = value['total_days'] * value['price_per_day']
logging.debug('made it through total_price')
# value['sqrt_total_price'] = math.sqrt(value['total_price'])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think how you could log particular errors that could happen (e.g., missing field, end date smaller than beginning date...) and what would be severity of these log messages.

@ObjectiveJoe ObjectiveJoe merged commit 6a3f2f9 into UWPCE-PythonCert-ClassRepos:master May 9, 2019
KevCav91 added a commit to KevCav91/Python220A_2019 that referenced this pull request Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants