feat(grid): add minchars and displaycount to search filter #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalinaCristian
force-pushed
the
fix/search-filter-changes
branch
from
63aa102 to
a80e899
Compare
anbalase
requested changes
Jan 26, 2023
Collaborator
anbalase
left a comment
anbalase
left a comment
There was a problem hiding this comment.
code looks good, pls add relevant tests
CalinaCristian
force-pushed
the
fix/search-filter-changes
branch
from
9351ad2 to
eb39f52
Compare
CalinaCristian
force-pushed
the
fix/search-filter-changes
branch
from
eb39f52 to
c46730f
Compare
anbalase
reviewed
Jan 26, 2023
CalinaCristian
force-pushed
the
fix/search-filter-changes
branch
from
c46730f to
48f5d45
Compare
anbalase
approved these changes
Jan 26, 2023
|
Code Climate has analyzed commit 48f5d45 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.6% (0.0% change). View more on Code Climate. |
gheorghitahurmuz
pushed a commit
that referenced
this pull request
Dec 12, 2023
feat(grid): add minchars and displaycount to search filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.