Skip to content

Conversation

@caleniuc
Copy link
Collaborator

When computing absolute time, if luxon was enabled and dateFormat was a string, we would still use moment.

@caleniuc caleniuc self-assigned this Feb 15, 2023
@caleniuc caleniuc force-pushed the fix/df-luxon-absolute-time branch from 6d81c1e to 08fdac7 Compare February 15, 2023 14:20
@caleniuc caleniuc force-pushed the fix/df-luxon-absolute-time branch from 08fdac7 to a39eafd Compare February 15, 2023 14:26
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit a39eafd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.7% (0.0% change).

View more on Code Climate.

@caleniuc caleniuc merged commit 979e27f into master Feb 15, 2023
@caleniuc caleniuc deleted the fix/df-luxon-absolute-time branch February 15, 2023 16:00
gheorghitahurmuz pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants