Skip to content

Conversation

@CatalinB7
Copy link
Collaborator

@CatalinB7 CatalinB7 commented May 24, 2023

TODO:

  • add tests

@CatalinB7 CatalinB7 requested review from a team, anbalase and caleniuc and removed request for a team May 24, 2023 12:26
@CatalinB7 CatalinB7 force-pushed the feat/grid_radio_btn branch 2 times, most recently from 684266f to 1533af0 Compare May 24, 2023 16:52
@CatalinB7 CatalinB7 force-pushed the feat/grid_radio_btn branch from 1533af0 to 5cd0ac6 Compare May 24, 2023 19:29
@CatalinB7 CatalinB7 changed the title Feat(grid): add radio btn select Feat(grid): add radio button selection May 25, 2023
tabindex="0">
</mat-checkbox>
</div>
<ng-container *ngLet="disableSelectionByEntry(row) as disabledReason">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I have both on?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, solved

@CatalinB7 CatalinB7 force-pushed the feat/grid_radio_btn branch 4 times, most recently from 170a03b to 111f9bb Compare May 29, 2023 07:49
caleniuc
caleniuc previously approved these changes May 29, 2023
@CatalinB7 CatalinB7 force-pushed the feat/grid_radio_btn branch from 313c0fc to ef3c5c5 Compare May 29, 2023 09:43
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit ef3c5c5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.8% (0.0% change).

View more on Code Climate.

@CatalinB7 CatalinB7 merged commit a76a5f2 into master May 29, 2023
@CatalinB7 CatalinB7 deleted the feat/grid_radio_btn branch May 29, 2023 10:06
gheorghitahurmuz pushed a commit that referenced this pull request Dec 12, 2023
Feat(grid): add radio button selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants