Skip to content

Conversation

@ioanajoj
Copy link
Collaborator

Description

  • do not highlight drag area when dragging event does not contain Files

Before
file-picker-disable-drag-anchors-before

After
file-picker-disable-drag-anchors-after

@ioanajoj ioanajoj requested a review from sergiubologa January 31, 2024 14:17
sergiubologa
sergiubologa previously approved these changes Jan 31, 2024
Copy link
Member

@sergiubologa sergiubologa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this scenario be tested with a unit test?

@ioanajoj ioanajoj force-pushed the fix/file-picker/highlight-applied-when-dragging-links branch from f991e32 to f58730e Compare February 1, 2024 16:29
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit f58730e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.3% (0.0% change).

View more on Code Climate.

sergiubologa
sergiubologa previously approved these changes Feb 2, 2024
@sergiubologa sergiubologa disabled auto-merge February 2, 2024 14:06
@sergiubologa sergiubologa merged commit d06517e into master Feb 2, 2024
@sergiubologa sergiubologa deleted the fix/file-picker/highlight-applied-when-dragging-links branch February 2, 2024 14:06
gheorghitahurmuz pushed a commit that referenced this pull request Feb 5, 2024
…-when-dragging-links

fix(file-picker): dropzone should only highlight when dragging files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants