Skip to content

Commit 041d4de

Browse files
ert78gbmondalaci
authored andcommitted
fix(app): Rename the title property of the uhk-message component (#460)
Renaming eliminate the default behaviour of the title attribute of the HTML elements.
1 parent f7cdbbb commit 041d4de

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<uhk-message title="Cannot find your UHK" subtitle="Please plug it in!"></uhk-message>
1+
<uhk-message header="Cannot find your UHK" subtitle="Please plug it in!"></uhk-message>
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<span class="privilege-checker-wrapper">
2-
<uhk-message title="Cannot talk to your UHK" subtitle="Your UHK has been detected, but its permissions are not set up yet, so Agent can't talk to it."></uhk-message>
2+
<uhk-message header="Cannot talk to your UHK" subtitle="Your UHK has been detected, but its permissions are not set up yet, so Agent can't talk to it."></uhk-message>
33
<button class="btn btn-default btn-lg btn-primary" (click)="setUpPermissions()"> Set up permissions </button>
4-
</span>
4+
</span>

packages/uhk-web/src/app/components/uhk-message/uhk-message.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
[ngClass]="{'spin-logo': rotateLogo}"
44
src="assets/images/agent-icon.png"/>
55
<div class="messages">
6-
<h1> {{ title }} </h1>
6+
<h1> {{ header }} </h1>
77
<h2> {{ subtitle }} </h2>
88
</div>
99
</span>

packages/uhk-web/src/app/components/uhk-message/uhk-message.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { Component, Input, ChangeDetectionStrategy } from '@angular/core';
77
changeDetection: ChangeDetectionStrategy.OnPush
88
})
99
export class UhkMessageComponent {
10-
@Input() title: string;
10+
@Input() header: string;
1111
@Input() subtitle: string;
1212
@Input() rotateLogo = false;
1313
}

packages/uhk-web/src/app/pages/loading-page/loading-device.page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { Component } from '@angular/core';
33
@Component({
44
selector: 'loading-device',
55
template: `
6-
<uhk-message title="Loading keyboard configuration..."
6+
<uhk-message header="Loading keyboard configuration..."
77
subtitle="Hang tight!"
88
[rotateLogo]="true"></uhk-message>
99
`

0 commit comments

Comments
 (0)