-
Notifications
You must be signed in to change notification settings - Fork 18
Only store failed tests mpl-pytest #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note this reasons from the perspective that all tests are run. It should be better to inverse the pattern (only store failed) but this way is easier and does not require an additional directory. |
|
The idea would be to host the full baseline on a separate repo and push the failed to readthedocs as suggested by @beckermr |
beckermr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to test this live by adding the flag, making a test fail, and ensuring the output looks correct.
|
Did this locally, but I will push an error now. |
758d5ce to
3853dbb
Compare
|
We need to add the flag to the pytest call too in order to test. |
beckermr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The artifacts are still ~90 MB and I see all of the plots in them. Something is not working here...
|
Will check later. |
2236386 to
9f8033e
Compare
|
Should be good now @beckermr |
|
I am trying a failure live again. |

Pytest does not allow to only store failed tests. This PR addresses this issue by providing a plugin that removes all successful tests from the results dir. It needs to be called as
This builds upon the issues raised in #103 #89