rm dep warning #210
Merged
rm dep warning #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
beckermr
approved these changes
May 11, 2025
Collaborator
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
LGTM. If we decide the effort is too much to support, then we can revisit.
cvanelteren
added a commit
that referenced
this pull request
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm personally a strong proponent of calling plot methods directly on a series of axes. With that in mind, I believe we should remove this method, as I intend to continue supporting that approach. That said, I'm open to discussion if there's an important consideration I'm overlooking. One of UltraPlot’s strengths is its ability to simplify the management of subplot properties while still allowing fine-grained control. For that reason, I suggest we remove this statement.