[pull] master from monkeytypegame:master #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and also include the author name at the end inside parenthesis. It looks like your proposed title needs to be adjusted. Details: A correct version would look something like: feat: add new feature (@github-username) |
1 similar comment
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and also include the author name at the end inside parenthesis. It looks like your proposed title needs to be adjusted. Details: A correct version would look something like: feat: add new feature (@github-username) |
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
…language doesnt have any quotes closes #6451
!nuf
… (#6459) because vite dev server does not throw a 404 when fetching a non existing json document, but responds with an html document and a 200 status code
### Description Add five Urdu Quotes ### Checks - [x] Adding quotes? - [x] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. --------- Co-authored-by: Miodec <jack@monkeytype.com>
…ng phantom theme (@fehmer) (#6446) 1. Some buttons have the color animation set like funboxes on the settings page while others have not:  2. On the active theme button the effects overlap making it unreadable:  3. On the footer color effect was applied to the `textButton` (like github, discord links) but not `button` (like contract and support). This applies to all animated themes.
### Description Adds Vesper theme. Based on Vesper for VSCode theme from [Rauno Freiberg](https://github.com/raunofreiberg/vesper) <!-- Please describe the change(s) made in your PR --> ### Checks - [ ] Adding quotes? - [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [x] Adding a language or a theme? - [ ] If is a language, did you edit `_list.json`, `_groups.json` and add `languages.json`? - [x] If is a theme, did you add the theme.css? - Also please add a screenshot of the theme, it would be extra awesome if you do so! - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. <!-- label(optional scope): pull request title (@your_github_username) --> <!-- I know I know they seem boring but please do them, they help us and you will find out it also helps you.--> ## Preview ### Main Page:  ### Settings Page:  ### Toasts: #### Error Toast:  #### Info Toast:  #### Success Toast:  <!-- the issue(s) your PR resolves if any (delete if that is not the case) --> <!-- please also reference any issues and or PRs related to your pull request --> <!-- Also remove it if you are not following any issues. --> <!-- pro tip: you can mention an issue, PR, or discussion on GitHub by referencing its hash number e.g: [#1234](#1234) --> <!-- pro tip: you can press . (dot or period) in the code tab of any GitHub repo to get access to GitHub's VS Code web editor Enjoy! :) -->
### Description Added layout mirror item in the funbox with functionality. Tweaked how active funbox items are detected in the commandline (names included in other names no long appear as active if the item they're included in is active). ### Checks - [ ] Adding quotes? - [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [ ] Adding a language or a theme? - [ ] If is a language, did you edit `_list.json`, `_groups.json` and add `languages.json`? - [ ] If is a theme, did you add the theme.css? - Also please add a screenshot of the theme, it would be extra awesome if you do so! - [X] Check if any open issues are related to this PR; if so, be sure to tag them below. - [X] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [X] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. <!-- label(optional scope): pull request title (@your_github_username) --> <!-- I know I know they seem boring but please do them, they help us and you will find out it also helps you.--> Closes #5573 <!-- the issue(s) your PR resolves if any (delete if that is not the case) --> <!-- please also reference any issues and or PRs related to your pull request --> <!-- Also remove it if you are not following any issues. --> <!-- pro tip: you can mention an issue, PR, or discussion on GitHub by referencing its hash number e.g: [#1234](#1234) --> <!-- pro tip: you can press . (dot or period) in the code tab of any GitHub repo to get access to GitHub's VS Code web editor Enjoy! :) --> --------- Co-authored-by: jeffrey <jeffrey.tiger@telecom-paris.fr> Co-authored-by: Miodec <jack@monkeytype.com>
### Description Add xhosa_3k ### Checks - [x] Adding a language or a theme? - [x] If is a language, did you edit `_list.json`, `_groups.json` and add `languages.json`? - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. --------- Co-authored-by: Miodec <jack@monkeytype.com>
extract icon getting code to a function cleanup code that builds command html update the placeholder of the input according to the active command group fix some icon alignment update some strings
### Description Fix missing colons and a single missing comma in the typescript codeblock for the theme preview #### Before  #### After  ### Checks - [ ] Adding quotes? - [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [ ] Adding a language? - Make sure to follow the [languages documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LANGUAGES.md) - [ ] Add language to `packages/contracts/src/schemas/languages.ts` - [ ] Add language to exactly one group in `frontend/src/ts/constants/languages.ts` - [ ] Add language json file to `frontend/static/languages` - [ ] Adding a theme? - Make sure to follow the [themes documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/THEMES.md) - [ ] Add theme to `packages/contracts/src/schemas/themes.ts` - [ ] Add theme to `frontend/src/ts/constants/themes.ts` - [ ] Add theme css file to `frontend/static/themes` - Also please add a screenshot of the theme, it would be extra awesome if you do so! - [ ] Adding a layout? - [ ] Make sure to follow the [layouts documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LAYOUTS.md) - [ ] Add layout to `packages/contracts/src/schemas/layouts.ts` - [ ] Add layout json file to `frontend/static/layouts` - [ ] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
1. config highlight was shown again if you - select a deep link - go to another page - go to the settings page 2. when closing a settings group with a highlight the animation broke 3. when opening a closed settings group with a highlight the animation was repeated
#6719) Highlight was not visible if the user has prefers-reduced-motion enabled.
…#6720) ### Description Added 4 English quotes from Better Call Saul ### Checks - [x] Adding quotes? - [x] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
…#6727) Description 15 polish movie quotes Checks Translations: Grzegorz Brzęczyszczykiewicz. Chrząszczyrzewoszczyce, Łękołody County.- "id":201 I am reporting obediently, Colonel, I caused this war completely unintentionally. - "id":202 Everyone can help their luck, everyone can win today. Black loses, red wins. One, two, three... - "id":203 He died on the way, certainly from his wounds. - It wasn't from his wounds, sir! The plum brandy!- "id":204 You, come here. Where are you going? Come here to the master. How good! What a pretty lady he has! Only she's so serious... And why is she so serious, huh? Fat... Well, come on. What, some good peppers? Eat, eat. If you don't eat, the lady will lock you up in a hole like us here. - "id":205 Darkness, I see darkness, I see darkness. - "id":206 Saved! We're saved! The stork! Look! The stork! If he's alive, that means we can too. Stork, stork!- "id":207 The league defends, the league advises, the league will never betray you! - "id":208 In a few days, sir, it will only begin: interviews, autographs, visits to workplaces. - "id":209 I, Prince Jeremi Wiśniowiecki, Voivode of Ruthenia, Lord of Łubnie and Wiśniowiec, swear to you, living God, one in the Holy Trinity, that I will not lay down this saber when I raise it against the scoundrels until I have pacified Ukraine and drowned the peasant rebellions in blood! So help me God! -"id":210 Maybe you want to wait until the drizzle stops. It's a shame to die in such rain. - They'll bury the colonel, so the sky is crying. - "id":211 You're swinging like a flail! - Stop it, spare the shame. - "id":212 Lithuania! My homeland! You are like health. How much you must be valued, only he who has lost you will know. Today I see and describe your beauty in all its splendor, because I miss you. - "id":213 I always told you – abandon the trials. I always told you – invade, invade! - "id":214 I have nothing, you have nothing, he has nothing... Together we have enough to set up a large factory.- "id":215 Co-authored-by: Tomasz.Sobczak <Tomasz.Sobczak@fujitsu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )