Skip to content

Conversation

@abdi42
Copy link

@abdi42 abdi42 commented Jul 5, 2017

When uploading images, as an admin user I would like to know if the upload was successful or not.

@streamtw
Copy link
Member

streamtw commented Jul 6, 2017

Thank you @abdi42 .

@streamtw streamtw merged commit d594091 into UniSharp:master Jul 6, 2017
@gwleuverink
Copy link
Collaborator

May I suggest an alternative approach? Since this is merged there is no way to opt-out of this feature. I don't want my clients to click to dismiss a popup every time a file has uploaded. Especially since a error message pops up when the upload fails.

What do you think about writing up a feature that uses the events you can listen to to modify the response and add an optional message propery. If the property exists, a popup message is show.

Besides acheiving what @abdi42 needs it also enhances the flexibility of all events that are raised.

What do you guys think about this?

@streamtw
Copy link
Member

streamtw commented Jul 6, 2017

@gwleuverink I got your point. Maybe we can use alerts as alternative. How do you think?

@gwleuverink
Copy link
Collaborator

@g0110280 That sounds great 👍 Alerts seem perfect since it allows the user to simply ignore it and move on. The error messages and such will still be displayed in a modal right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants