iosBuildStepsUpdate: project+workspace steps added #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rinal
requested changes
Jun 3, 2022
Collaborator
Rinal
left a comment
Rinal
left a comment
There was a problem hiding this comment.
Please check PR comments
Update the package version in the current PR
| menuName = MenuPaths.IOS + nameof(Archive) | ||
| )] | ||
| public sealed class Archive : IosPostBuildStep | ||
| public class Archive : IosPostBuildStep |
| [SerializeField] private PathProperty m_outputPath = new PathProperty("Unity-iPhone.xcarchive"); | ||
| [SerializeField] private string m_scheme = "Unity-iPhone"; | ||
| [SerializeField] private bool m_useModernBuildSystem = true; | ||
| protected virtual string CommandStart { get; set; } |
Contributor
Author
|
@Rinal please, check updated PR |
Rinal
requested changes
Jun 3, 2022
Collaborator
Rinal
left a comment
Rinal
left a comment
There was a problem hiding this comment.
Please add a new package version
Contributor
Author
|
@Rinal package version updated |
Rinal
approved these changes
Jun 3, 2022
Collaborator
Rinal
left a comment
Rinal
left a comment
There was a problem hiding this comment.
Good job, ready for a merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.