unpin xarray, numpy, pandas, netcdf4 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
August 30, 2022 16:27
…ariable is ambiguous, please extract the data using the .data property." See pydata/xarray#6508. There are other errors, however.
… 1.5.8 and 1.6.0".
… in xarray 2022.06. Update tests for same.
… = 1.23.2, xarray = 2022.06.0. That means it has nothing to do with BrainIO.
… test for bugs in xarray. With xarray==2022.06.0, this test fails.
…nd 2022.06.0. Now test_get_metadata passes under 2022.03.0 and 2022.06.0.
…: NetCDF: Filter error: bad id or parameters or duplicate filter. This might fix it?
…compression has an effect.
jjpr-mit
approved these changes
Sep 26, 2022
jjpr-mit
left a comment
jjpr-mit
left a comment
There was a problem hiding this comment.
Unfortunately we still have to block a version of xarray because it has a bug. Otherwise, there are now better tests, and they're all passing.
|
@mschrimpf Do you want to review again before we merge? |
Member
Author
|
Looks good, let's merge. Thanks @jjpr-mit! |
mschrimpf
added a commit
to mschrimpf/brain-score
that referenced
this pull request
Sep 29, 2022
following xarray unpin in brain-score/brainio#25
mschrimpf
added a commit
to brain-score/vision
that referenced
this pull request
Oct 11, 2022
* add `reduce` method to `Score` class for newer xarray following xarray unpin in brain-score/brainio#25 * cast `condition` coordinate to string * also cast `condition` to str for precomputed features * cast clip output to original assembly type see also brain-score/brainio#27 * keep `importlib-metadata` at version 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the brain-score
Scoretests, they all pass.Remaining errors are up to you @jjpr-mit