contracts: drop swapOutput #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrobinson
force-pushed
the
dropSwapOutput
branch
from
660a849 to
346c642
Compare
haydenadams
approved these changes
Oct 1, 2019
0xBeaver
pushed a commit
to 0xBeaver/uniswap-v2-core
that referenced
this pull request
Jun 25, 2021
contracts: drop swapOutput
Gilgames000
pushed a commit
to LeetSwap/v2-core
that referenced
this pull request
Aug 13, 2023
Co-authored-by: Noah Marconi <noah.marconi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the swapOutput and getOutputPrice functions from the ERC20-ERC20 contract. We now think they can be implemented in the wrapper.