Skip to content

Fixed split implementation in the wrapper for String class and fixed some warnings in tests for String #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fixed split implementation in the wrapper for String class and fixed some warnings in tests for String #1615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 32 additions & 16 deletions utbot-framework-test/src/test/kotlin/org/utbot/examples/strings/StringExamplesTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@ import org.utbot.testcheckers.withSolverTimeoutInMillis
import org.utbot.testcheckers.withoutMinimization
import org.utbot.testing.CodeGeneration
import org.utbot.testing.DoNotCalculate
import org.utbot.testing.FullWithAssumptions
import org.utbot.testing.UtValueTestCaseChecker
import org.utbot.testing.atLeast
import org.utbot.testing.between
import org.utbot.testing.ignoreExecutionsNumber
import org.utbot.testing.isException
import org.utbot.testing.keyMatch
import java.util.Locale

internal class StringExamplesTest : UtValueTestCaseChecker(
testClass = StringExamples::class,
Expand Down Expand Up @@ -161,7 +163,7 @@ internal class StringExamplesTest : UtValueTestCaseChecker(
{ v, _ -> v == null },
{ v, r -> v != null && v.startsWith("1234567890") && r!!.startsWith("12a4567890") },
{ v, r -> v != null && v[0] == 'x' && r!![0] == 'x' },
{ v, r -> v != null && v.toLowerCase() == r }
{ v, r -> v != null && v.lowercase(Locale.getDefault()) == r }
)
}

Expand Down Expand Up @@ -245,7 +247,7 @@ internal class StringExamplesTest : UtValueTestCaseChecker(
check(
StringExamples::concat,
between(1..2),
{ fst, snd, r -> fst == null || snd == null && r == fst + snd },
{ fst, snd, r -> (fst == null || snd == null) && r == fst + snd },
{ fst, snd, r -> r == fst + snd },
)
}
Expand Down Expand Up @@ -327,9 +329,9 @@ internal class StringExamplesTest : UtValueTestCaseChecker(
check(
StringExamples::isValidUuid,
ignoreExecutionsNumber,
{ uuid, r -> uuid == null || uuid.length == 0 && r == false },
{ uuid, r -> uuid.length > 0 && uuid.isBlank() && r == false },
{ uuid, r -> uuid.length > 0 && uuid.isNotBlank() && r == false },
{ uuid, r -> uuid == null || uuid.isEmpty() && r == false },
{ uuid, r -> uuid.isNotEmpty() && uuid.isBlank() && r == false },
{ uuid, r -> uuid.isNotEmpty() && uuid.isNotBlank() && r == false },
{ uuid, r -> uuid.length > 1 && uuid.isNotBlank() && !uuid.matches(pattern) && r == false },
{ uuid, r -> uuid.length > 1 && uuid.isNotBlank() && uuid.matches(pattern) && r == true },
)
Expand All @@ -347,15 +349,29 @@ internal class StringExamplesTest : UtValueTestCaseChecker(
)
}

@Test
fun testSplitExample() {
check(
StringExamples::splitExample,
ignoreExecutionsNumber,
{ s, r -> s.all { it.isWhitespace() } && r == 0 },
{ s, r -> s.none { it.isWhitespace() } && r == 1 },
{ s, r -> s[0].isWhitespace() && s.any { !it.isWhitespace() } && r == 2 },
{ s, r -> !s[0].isWhitespace() && s[2].isWhitespace() && r == 1 },
{ s, r -> !s[0].isWhitespace() && s[1].isWhitespace() && !s[2].isWhitespace() && r == 2 },
coverage = FullWithAssumptions(assumeCallsNumber = 2)
)
}

@Test
fun testIsBlank() {
check(
StringExamples::isBlank,
ge(4),
{ cs, r -> cs == null && r == true },
{ cs, r -> cs.length == 0 && r == true },
{ cs, r -> cs.length > 0 && cs.isBlank() && r == true },
{ cs, r -> cs.length > 0 && cs.isNotBlank() && r == false },
{ cs, r -> cs.isEmpty() && r == true },
{ cs, r -> cs.isNotEmpty() && cs.isBlank() && r == true },
{ cs, r -> cs.isNotEmpty() && cs.isNotBlank() && r == false },
summaryNameChecks = listOf(
keyMatch("testIsBlank_StrLenEqualsZero"),
keyMatch("testIsBlank_NotCharacterIsWhitespace"),
Expand Down Expand Up @@ -541,9 +557,9 @@ internal class StringExamplesTest : UtValueTestCaseChecker(
check(
StringExamples::endsWith,
between(5..6),
{ s, suffix, r -> suffix == null },
{ s, suffix, r -> suffix != null && suffix.length < 2 },
{ s, suffix, r -> suffix != null && suffix.length >= 2 && s == null },
{ _, suffix, _ -> suffix == null },
{ _, suffix, _ -> suffix != null && suffix.length < 2 },
{ s, suffix, _ -> suffix != null && suffix.length >= 2 && s == null },
{ s, suffix, r -> suffix != null && suffix.length >= 2 && s != null && s.endsWith(suffix) && r == true },
{ s, suffix, r -> suffix != null && suffix.length >= 2 && s != null && !s.endsWith(suffix) && r == false }
)
Expand Down Expand Up @@ -609,10 +625,10 @@ internal class StringExamplesTest : UtValueTestCaseChecker(
checkWithException(
StringExamples::compareCodePoints,
between(8..10),
{ s, t, i, r -> s == null && r.isException<NullPointerException>() },
{ s, t, i, r -> s != null && i < 0 || i >= s.length && r.isException<StringIndexOutOfBoundsException>() },
{ s, t, i, r -> s != null && t == null && r.isException<NullPointerException>() },
{ s, t, i, r -> t != null && i < 0 || i >= t.length && r.isException<StringIndexOutOfBoundsException>() },
{ s, _, _, r -> s == null && r.isException<NullPointerException>() },
{ s, _, i, r -> s != null && i < 0 || i >= s.length && r.isException<StringIndexOutOfBoundsException>() },
{ s, t, _, r -> s != null && t == null && r.isException<NullPointerException>() },
{ _, t, i, r -> t != null && i < 0 || i >= t.length && r.isException<StringIndexOutOfBoundsException>() },
{ s, t, i, r -> s != null && t != null && s.codePointAt(i) < t.codePointAt(i) && i == 0 && r.getOrThrow() == 0 },
{ s, t, i, r -> s != null && t != null && s.codePointAt(i) < t.codePointAt(i) && i != 0 && r.getOrThrow() == 1 },
{ s, t, i, r -> s != null && t != null && s.codePointAt(i) >= t.codePointAt(i) && i == 0 && r.getOrThrow() == 2 },
Expand All @@ -625,7 +641,7 @@ internal class StringExamplesTest : UtValueTestCaseChecker(
check(
StringExamples::toCharArray,
eq(2),
{ s, r -> s == null },
{ s, _ -> s == null },
{ s, r -> s.toCharArray().contentEquals(r) }
)
}
Expand Down
2 changes: 2 additions & 0 deletions utbot-framework/src/main/java/org/utbot/engine/overrides/strings/UtString.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,10 +857,12 @@ public String[] split(String regex, int limit) {
}

private String[] splitImpl(String regex) {
executeConcretely();
return toString().split(regex);
}

public String[] split(String regex) {
preconditionCheck();
return splitImpl(regex);
}

Expand Down
45 changes: 45 additions & 0 deletions utbot-sample/src/main/java/org/utbot/examples/strings/StringExamples.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.utbot.examples.strings;

import org.jetbrains.annotations.NotNull;
import org.utbot.api.mock.UtMock;

import java.util.Arrays;

Expand Down Expand Up @@ -236,6 +237,50 @@ public boolean isValidUuidShortVersion(String uuid) {
return uuid != null && uuid.matches("[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}");
}

@SuppressWarnings("IfStatementWithIdenticalBranches")
public int splitExample(String s) {
UtMock.assume(s != null);
UtMock.assume(s.length() == 3);

final char firstChar = s.charAt(0);
final char secondChar = s.charAt(1);
final char thirdChar = s.charAt(2);

final boolean isFirstWhitespace = Character.isWhitespace(firstChar);
final boolean isSecondWhitespace = Character.isWhitespace(secondChar);
final boolean isThirdWhitespace = Character.isWhitespace(thirdChar);

if (isFirstWhitespace) {
if (isSecondWhitespace) {
if (isThirdWhitespace) {
return s.split("\\s+").length;
} else {
return s.split("\\s+").length;
}
} else {
if (isThirdWhitespace) {
return s.split("\\s+").length;
} else {
return s.split("\\s+").length;
}
}
} else {
if (isSecondWhitespace) {
if (isThirdWhitespace) {
return s.split("\\s+").length;
} else {
return s.split("\\s+").length;
}
} else {
if (isThirdWhitespace) {
return s.split("\\s+").length;
} else {
return s.split("\\s+").length;
}
}
}
}

public boolean isNotBlank(CharSequence cs) {
return !isBlank(cs);
}
Expand Down