Skip to content

Remove undue 'byFuzzer' suffix rendering #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Remove undue 'byFuzzer' suffix rendering #1673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 48 additions & 66 deletions utbot-summary/src/main/kotlin/org/utbot/summary/Summarization.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,12 @@ class Summarization(val sourceFile: File?, val invokeDescriptions: List<InvokeDe
when (summaryGenerationType) {
SummariesGenerationType.FULL -> {
executionClusters += generateSummariesForTestsWithNonEmptyPathsProducedBySymbolicExecutor(testSet)
executionClusters += generateSummariesForTestsProducedByFuzzer(testSet)
executionClusters += generateFuzzerBasedSummariesForTests(testSet)
executionClusters += generateSummariesForTestsWithEmptyPathsProducedBySymbolicExecutor(testSet)
}
SummariesGenerationType.LIGHT -> {
executionClusters += generateSummariesForTestsProducedBySymbolicExecutorWithoutSources(testSet)
executionClusters += generateSummariesForTestsProducedByFuzzer(testSet)
executionClusters += generateFuzzerBasedSummariesForTests(testSet, MethodDescriptionSource.SYMBOLIC)
executionClusters += generateFuzzerBasedSummariesForTests(testSet)
}
SummariesGenerationType.NONE -> error("We must not fill summaries if SummariesGenerationType is NONE")
}
Expand Down Expand Up @@ -228,83 +228,56 @@ class Summarization(val sourceFile: File?, val invokeDescriptions: List<InvokeDe
return clustersToReturn.toList()
}

private fun generateSummariesForTestsProducedBySymbolicExecutorWithoutSources(
testSet: UtMethodTestSet
) : List<UtExecutionCluster> {
val clustersToReturn: MutableList<UtExecutionCluster> = mutableListOf()

val testSetWithFuzzedExecutions = prepareTestSetForByteCodeAnalysis(testSet)
val executions = testSetWithFuzzedExecutions.executions as List<UtSymbolicExecution>

if (executions.isNotEmpty()) {
executions.forEach { utExecution ->

val nameSuggester = sequenceOf(ModelBasedNameSuggester(), MethodBasedNameSuggester())
val testMethodName = try {
nameSuggester.flatMap {
val executableId = testSet.method
val description = FuzzedMethodDescription(executableId).apply {
compilableName = if (!executableId.isConstructor) executableId.name else null
}
it.suggest(
description,
utExecution.stateBefore.parameters.map { value -> FuzzedValue(value) },
utExecution.result
)
}.firstOrNull()
} catch (t: Throwable) {
logger.error(t) { "Cannot create suggested test name for $utExecution" }
null
}
utExecution.testMethodName = testMethodName?.testName
utExecution.displayName = testMethodName?.displayName
utExecution.summary = testMethodName?.javaDoc
}

val clusteredExecutions = groupFuzzedExecutions(testSetWithFuzzedExecutions)
clusteredExecutions.forEach {
clustersToReturn.add(
UtExecutionCluster(
UtClusterInfo(it.header),
it.executions
)
)
}
}

return clustersToReturn.toList()
}

private fun generateSummariesForTestsProducedByFuzzer(
testSet: UtMethodTestSet
private fun generateFuzzerBasedSummariesForTests(
testSet: UtMethodTestSet,
descriptionSource: MethodDescriptionSource = MethodDescriptionSource.FUZZER
): List<UtExecutionCluster> {
val clustersToReturn: MutableList<UtExecutionCluster> = mutableListOf()
val testSetWithFuzzedExecutions = prepareTestSetWithFuzzedExecutions(testSet)
val executionsProducedByFuzzer = testSetWithFuzzedExecutions.executions as List<UtFuzzedExecution>

if (executionsProducedByFuzzer.isNotEmpty()) {
executionsProducedByFuzzer.forEach { utExecution ->
val methodTestSet = when (descriptionSource) {
MethodDescriptionSource.FUZZER -> prepareTestSetWithFuzzedExecutions(testSet)
MethodDescriptionSource.SYMBOLIC -> prepareTestSetForByteCodeAnalysis(testSet)
}

val nameSuggester = sequenceOf(ModelBasedNameSuggester(), MethodBasedNameSuggester())
if (methodTestSet.executions.isNotEmpty()) {
methodTestSet.executions.forEach { utExecution ->
val nameSuggester = sequenceOf(ModelBasedNameSuggester(), MethodBasedNameSuggester(descriptionSource))
val testMethodName = try {
nameSuggester.flatMap {
it.suggest(
utExecution.fuzzedMethodDescription as FuzzedMethodDescription,
utExecution.fuzzingValues as List<FuzzedValue>,
utExecution.result
)
when (descriptionSource) {
MethodDescriptionSource.FUZZER -> {
with(utExecution as UtFuzzedExecution) {
it.suggest(
utExecution.fuzzedMethodDescription as FuzzedMethodDescription,
utExecution.fuzzingValues as List<FuzzedValue>,
utExecution.result
)
}
}

MethodDescriptionSource.SYMBOLIC -> {
val executableId = testSet.method
val description = FuzzedMethodDescription(executableId).apply {
compilableName = if (!executableId.isConstructor) executableId.name else null
}
it.suggest(
description,
utExecution.stateBefore.parameters.map { value -> FuzzedValue(value) },
utExecution.result
)
}
}
}.firstOrNull()
} catch (t: Throwable) {
logger.error(t) { "Cannot create suggested test name for $utExecution" } // TODO: add better explanation or default behaviour
null
}

utExecution.testMethodName = testMethodName?.testName
utExecution.displayName = testMethodName?.displayName
utExecution.summary = testMethodName?.javaDoc
}

val clusteredExecutions = groupFuzzedExecutions(testSetWithFuzzedExecutions)

val clusteredExecutions = groupFuzzedExecutions(methodTestSet)
clusteredExecutions.forEach {
clustersToReturn.add(
UtExecutionCluster(
Expand Down Expand Up @@ -445,4 +418,13 @@ private fun invokeDescriptions(testSet: UtMethodTestSet, searchDirectory: Path):
}
}

data class InvokeDescription(val sootMethod: SootMethod, val ast: MethodDeclaration)
data class InvokeDescription(val sootMethod: SootMethod, val ast: MethodDeclaration)

/**
* Sometimes, we need to use fuzzer for preparing summaries even for [UtSymbolicExecution]s.
* See [Summarization.generateFuzzerBasedSummariesForTests].
*/
enum class MethodDescriptionSource {
FUZZER,
SYMBOLIC,
}
14 changes: 11 additions & 3 deletions utbot-summary/src/main/kotlin/org/utbot/summary/fuzzer/names/MethodBasedNameSuggester.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,17 @@ package org.utbot.summary.fuzzer.names
import org.utbot.framework.plugin.api.UtExecutionResult
import org.utbot.fuzzer.FuzzedMethodDescription
import org.utbot.fuzzer.FuzzedValue
import org.utbot.summary.MethodDescriptionSource

class MethodBasedNameSuggester : NameSuggester {
override fun suggest(description: FuzzedMethodDescription, values: List<FuzzedValue>, result: UtExecutionResult?): Sequence<TestSuggestedInfo> {
return sequenceOf(TestSuggestedInfo("test${description.compilableName?.capitalize() ?: "Created"}ByFuzzer"))
class MethodBasedNameSuggester(private val source: MethodDescriptionSource = MethodDescriptionSource.FUZZER) : NameSuggester {
override fun suggest(
description: FuzzedMethodDescription,
values: List<FuzzedValue>,
result: UtExecutionResult?
): Sequence<TestSuggestedInfo> {
val compilableName = description.compilableName?.capitalize() ?: "Created"
// See [Summarization.generateSummariesForTests].
val suffix = if (source == MethodDescriptionSource.FUZZER) "ByFuzzer" else ""
return sequenceOf(TestSuggestedInfo("test${compilableName}${suffix}"))
}
}