Skip to content

Fix broken AndroidProjectInfo.requiresAnroidModel() in new API #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

Fix broken AndroidProjectInfo.requiresAnroidModel() in new API #1951

merged 1 commit into from
Mar 15, 2023

Conversation

@Vassiliy-Kudryashov
Copy link
Member

@Vassiliy-Kudryashov Vassiliy-Kudryashov commented Mar 14, 2023

Description

Actually required method was inlined to our code

Fixes #1949

How to test

Manual tests

See the issue, adding new library (JUnit/Mockito etc.) shouldn't fail.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@Vassiliy-Kudryashov
boolean com.android.tools.idea.project.AndroidProjectInfo.requiresAnd…
7dd60da 
…roidModel() when dependency installation is required #1949
@Vassiliy-Kudryashov Vassiliy-Kudryashov added comp-ide Issue is related to IDE support ctg-bug-fix PR is fixing a bug labels Mar 14, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov linked an issue Mar 14, 2023 that may be closed by this pull request
boolean com.android.tools.idea.project.AndroidProjectInfo.requiresAndroidModel() when dependency installation is required #1949
Closed
@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) March 14, 2023 16:44
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 9f65396 into main Mar 15, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/1949-boolean-comandroidtoolsideaprojectandroidprojectinforequiresandroidmodel-when-dependency-installation-is-required branch March 15, 2023 10:09
Vassiliy-Kudryashov added a commit that referenced this pull request Mar 21, 2023
@Vassiliy-Kudryashov
Fix broken AndroidProjectInfo.requiresAnroidModel() in new API (#1951)
f77d45d
@alisevych alisevych added this to the 2023.03 Release milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes

Assignees

No one assigned

Labels

comp-ide Issue is related to IDE support ctg-bug-fix PR is fixing a bug

Projects

None yet

Milestone

2023.3 Release

Development

Successfully merging this pull request may close these issues.

boolean com.android.tools.idea.project.AndroidProjectInfo.requiresAndroidModel() when dependency installation is required

4 participants

@Vassiliy-Kudryashov @EgorkaKulikov @alisevych