Skip to content

Fallback to using ThrowableModel if serializing exception to bytes fails #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fallback to using ThrowableModel if serializing exception to bytes fails #2334

merged 1 commit into from
Jul 3, 2023

Conversation

@IlyaMuravjov
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov commented Jun 29, 2023

Description

Fixes error described in this comment

How to test

Scenario from issue #2323

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@IlyaMuravjov IlyaMuravjov added ctg-enhancement New feature, improvement or change request comp-instrumented-process Issue is related to Instrumented process ctg-bug-fix PR is fixing a bug comp-spring Issue is related to Spring projects support labels Jun 29, 2023
@IlyaMuravjov IlyaMuravjov changed the title Fallback to using ThrowableModel if serializing exception to bytes … Fallback to using ThrowableModel if serializing exception to bytes fails Jun 29, 2023
@EgorkaKulikov EgorkaKulikov merged commit fb98d56 into main Jul 3, 2023
@EgorkaKulikov EgorkaKulikov deleted the ilya_m/throwable_serializer branch July 3, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergeypospelov sergeypospelov sergeypospelov approved these changes

Assignees

No one assigned

Labels

comp-instrumented-process Issue is related to Instrumented process comp-spring Issue is related to Spring projects support ctg-bug-fix PR is fixing a bug ctg-enhancement New feature, improvement or change request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IlyaMuravjov @sergeypospelov @EgorkaKulikov