Skip to content

Conversation

@sofurihafe
Copy link
Member

@sofurihafe sofurihafe commented Jun 29, 2023

Description

Fixes #2357, #2220

  • Use TestContextManager when running tests
  • Make ValueConstructionPhase handle exceptions using standard mechanism of handling exceptions in ExecutionPhases
  • Make SpringUtExecutionInstrumentation only transform user sources

How to test

Manual tests

Generate integration tests for spring-boot-testing-main, spring-pet-clinic, and other Spring projects.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@sofurihafe sofurihafe added ctg-enhancement New feature, improvement or change request comp-spring Issue is related to Spring projects support labels Jun 29, 2023
@EgorkaKulikov EgorkaKulikov marked this pull request as ready for review July 3, 2023 11:05
@EgorkaKulikov EgorkaKulikov self-requested a review July 3, 2023 11:06
@IlyaMuravjov IlyaMuravjov added the comp-instrumented-process Issue is related to Instrumented process label Jul 3, 2023
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments will be addressed in a separate pull request, this pull request need to be merged now to avoid conflicts with @sofurihafe who is about to start making new improvements to updated parts of the project.

@EgorkaKulikov
Copy link
Collaborator

LGTM, requested some optional naming improvements personally.

@EgorkaKulikov EgorkaKulikov merged commit 84da87e into main Jul 6, 2023
@EgorkaKulikov EgorkaKulikov deleted the andrey-t/test_context_manager branch July 6, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-instrumented-process Issue is related to Instrumented process comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request

Projects

None yet

4 participants