Skip to content

Conversation

adrien-de-tocqueville
Copy link
Contributor

@adrien-de-tocqueville adrien-de-tocqueville commented Oct 8, 2020

Purpose of this PR

Fix https://fogbugz.unity3d.com/f/cases/1217722/
The HDRP and SG decal materials had no scene selection pass so picking didn't work in the editor

Unlike what's stated in the bug report, hdrp decal picking didn't work for me either, so I fixed it for both materials.
Actually it appears they could only be selected when clicking on a backface, but now it works


Testing status

Tested decal picking on the repro scene with HDRP and SG materials

@sebastienlagarde
Copy link
Contributor

sebastienlagarde commented Oct 9, 2020

Please sure to test with both decal projector and mesh decal. + Need to check with Yamato as changing the order of passes is always tricky in decal. Lastly, be sure that the stripper which removed selectionpass variant for regular shader also apply on decal shader :)

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md
@adrien-de-tocqueville
Copy link
Contributor Author

Decal projector still don't work but we agreed it's not necessary. Yamato seems ok with the changes
I am not sure how to test the stripper but looking at the code it looks like it should work ^^

Copy link
Contributor

@sebastienlagarde sebastienlagarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to think more about this, but I have hard time to figure out how it works , as code is separate between projector and mesh (and we used shaderpass to identify it), but the selection pass can't make this distinction.

@adrien-de-tocqueville adrien-de-tocqueville removed the request for review from a team October 14, 2020 14:59
@adrien-de-tocqueville adrien-de-tocqueville marked this pull request as draft October 14, 2020 15:00
@adrien-de-tocqueville
Copy link
Contributor Author

Replaced by #2234

@adrien-de-tocqueville adrien-de-tocqueville deleted the HDRP/decal-selection-pass branch October 19, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants