Fix backface and displacement picking for HDRP #2234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md
Closed
|
It appears that you made a non-draft PR! |
TomasKiniulis
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Checked all SG and HDRP shaders, backfaces are correctly ignored now(except for unlit since it's handled by another pr and tessellation).
For tessellation shaders I've filed a ticket here so it wouldn't get lost in the future: https://fogbugz.unity3d.com/f/cases/1285367/
Like Adrien mentions selection also ignores tessellation displacement and should be taken into account
sebastienlagarde
changed the title
com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/PickingSpaceTransforms.hlsl
Outdated
Show resolved
Hide resolved
sebastienlagarde
changed the title
adrien-de-tocqueville
changed the title
sebastienlagarde
approved these changes
Oct 27, 2020
sebastienlagarde
added a commit
that referenced
this pull request
Oct 27, 2020
* Scene selection pass * Don't cull backfaces * changelog * Lit Shader picking pass * hdrp shaders * Added ScenePickingPass to ShaderGraph * Fixes for decals * Tessellation picking * Update Upgrading-from-2020.1-to-2020.2.md * Move function to common.hlsl * Reorder decal passes * Minor changes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix for https://fogbugz.unity3d.com/f/cases/1282977/
and https://fogbugz.unity3d.com/f/cases/1217722/
Add a ScenePicking Pass to most shaders to have a custom picking
This allows to have picking depend on the material culling mode and to be able to correclty pick objects with vertex displacement.
This is done on HDRP Lit, LayeredLit, AxF, and Decal shaders and ShaderGraphs
[OUTDATED: This PR doesn't change anything for LitTessellation and LayeredLitTessellation so they are still 'broken']
Fix for https://fogbugz.unity3d.com/f/cases/1285370/
and https://fogbugz.unity3d.com/f/cases/1285367/
Tessellation picking now works correclty
The Unlit shader as well as URP shaders will be fixed by this PR:
https://ono.unity3d.com/unity/unity/pull-request/114181/_/editor/fix-picking-raster-state
Decal projectors cannot be picked because they are not taken into account by the picking pass.
To sum up, every object picking should be correct, with or without vertex displacement/tessellation
Materials for test scenes are upgraded in #2349
Testing status
Tested picking of front and back faces of all aforementionned materials with alpha transparency and vertex displacement.
Tested the repro scene given in the second bug case
Lit Tessellation show selected outline on backfaces
Lit Tessellation picking with vertex displacement
