Skip to content

Conversation

anisunity
Copy link
Contributor

This PR adds support of ray tracing effects for the eye shader. Now the additional sub-shaders required are properly generated.

Testings status

  • Added an eye SG for the reflection tests (so eye works with RT reflections) and it looks similar to what is seen in the direct view
  • Changed the Shadow test now that Eye SG is supported
  • Ran the DXR tests locally they are green.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@sebastienlagarde
Copy link
Contributor

@remi-chapelain I will expect that added test are enough.

@sebastienlagarde sebastienlagarde merged commit a97a485 into HDRP/staging Oct 14, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/raytracing-support-eye-shader branch October 14, 2020 19:31
@remi-chapelain
Copy link
Contributor

It's better than nothing, but I will try to add a more detailled test (like the 902_materials_variants) to catch regressions possible regressions better when I'll do a pass on it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants