Added a new material variant eye DXR test scene #2305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the cornea refraction function to take a view dir in object space.
Updating SSS RT material screenshots.
|
Ok On this PR i fixed the Eye shader now it looks how it should on RTR and RR.
Adding seb to the review |
|
Given that SSS was not properly managed for ray tracing effects in quality, i had to update other screenshots |
anisunity
force-pushed
the
HDRP/add-dxr-eye-variant-test-scene
branch
from
69e4efe to
04833b0
Compare
sebastienlagarde
approved these changes
Oct 26, 2020
Adjusting the DXR test scene
|
Now that @anisunity solved the issue everything looks correct in RTR and RR ✔️ |
anisunity
approved these changes
Oct 27, 2020
sebastienlagarde
pushed a commit
that referenced
this pull request
Oct 27, 2020
* - Fixed the object space matrices in shader graph for ray tracing. - Changed the cornea refraction function to take a view dir in object space. * Adding better coverage for the eye shader graph Updating SSS RT material screenshots. * Updating the eye SG and material for the regular test Adjusting the DXR test scene Co-authored-by: Anis Benyoub <anis@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Add automation coverage for the recent support of eye shader in DXR
Since we discovered a bunch of issue with this new test (Primarily SSS was not managed properly with Ray Tracing effects in quality), this PR also addresses them and now the test looks correct in Ray traced Reflections and Recursive Rendering
Testing status
Verified that nothing broke in other test and that the eye shader reflections looks correct in the new scene