[VFX] Remove Exact Fixed Time option #2507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to avoid unexpected behavior
Actually, doesn't break editor test because Sanitize is only call on the first import (or opening the graph).
|
@julienf-unity As discussed on slack, use a sanitize instead of doing this in inspector at 9ea36db Here an execution after loading the repro project ⬇️ Actually, I thought I had to update editor test but we can still test spawner behavior because the sanitize is only called on the first import (or opening the VisualEffectGraph window), added a explicit check of update mode after reimporting asset. |
julienf-unity
approved these changes
Nov 3, 2020
|
VFX_HDRP playmode : Expected result due to the unexpected message |
|
🟢 (kind of), ready to be merged ! |
julienf-unity
deleted the
vfx/fix/1289829-workaround-disabling-exact-fixed-time-step
branch
PaulDemeulenaere
added a commit
that referenced
this pull request
Nov 3, 2020
* Remove temporarily "Exact Fixed Time Step" option on VisualEffectAsset to avoid unexpected behavior * Use santize instead of inspector behavior to remove ExactFixedTimeStep Actually, doesn't break editor test because Sanitize is only call on the first import (or opening the graph).
julienf-unity
pushed a commit
that referenced
this pull request
Nov 4, 2020
* Remove temporarily "Exact Fixed Time Step" option on VisualEffectAsset to avoid unexpected behavior * Use santize instead of inspector behavior to remove ExactFixedTimeStep Actually, doesn't break editor test because Sanitize is only call on the first import (or opening the graph).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
We detected an unexpected behavior with Exact Fixed Time Step option on the VisualEffectGraph :
See case : https://fogbugz.unity3d.com/f/cases/1289829/
The actual fix require a C++ change, which can't be deliver before 10.2, so, we are temporarily removing this option in VisualEffect inspector.
The inspector will also reset the
VFXUpdateMode.ExactFixedTimeSteplogging the sanitize has been done.Testing status
Manual Only
Before
After
Comments to reviewers
This feature was exposed to user in 2020.1/2020.2, so :
It will be update with this PR [8.x.x] [VFX] Add Update Mode inspector in VisualEffectAsset #1131