Skip to content

[10.x.x][VFX] backport Remove Exact Fixed Time option (#2507) #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2020
Merged

[10.x.x][VFX] backport Remove Exact Fixed Time option (#2507) #2516

merged 1 commit into from
Nov 4, 2020

Conversation

PaulDemeulenaere
Copy link
Contributor

Purpose of this PR

Backport of #2507

@PaulDemeulenaere
[VFX] Remove Exact Fixed Time option (#2507)
fb7440e 
* Remove temporarily "Exact Fixed Time Step" option on VisualEffectAsset to avoid unexpected behavior

* Use santize instead of inspector behavior to remove ExactFixedTimeStep

Actually, doesn't break editor test because Sanitize is only call on the first import (or opening the graph).
@PaulDemeulenaere PaulDemeulenaere marked this pull request as ready for review November 3, 2020 17:42
@PaulDemeulenaere PaulDemeulenaere changed the title [VFX] Remove Exact Fixed Time option (#2507) backport [VFX] Remove Exact Fixed Time option (#2507) 10.x.x Nov 3, 2020
@PaulDemeulenaere
Copy link
Contributor Author

@julienf-unity Ready to be merged, as usual 🟢:

[19:22:02.020 INF] [48/96] TestFinish
	name: UnityEngine.VFX.Test.VFXGraphicsTests.SimpleLit
	result: FAILED
	message: Unhandled log message: '[Assert] Converting invalid MinMaxAABB'. Use UnityEngine.TestTools.LogAssert.Expect

@PaulDemeulenaere PaulDemeulenaere changed the title [VFX] Remove Exact Fixed Time option (#2507) 10.x.x [10.x.x][VFX] backport Remove Exact Fixed Time option (#2507) Nov 4, 2020
@julienf-unity julienf-unity merged commit e6e74e2 into 10.x.x/release Nov 4, 2020
@julienf-unity julienf-unity deleted the 10.x.x/vfx/fix/1289829-workaround-disabling-exact-fixed-time-step branch November 4, 2020 20:56
@PaulDemeulenaere PaulDemeulenaere mentioned this pull request Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julienf-unity julienf-unity julienf-unity approved these changes

Assignees

No one assigned

Labels

testing vfx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaulDemeulenaere @julienf-unity