Skip to content

Fixed useless editor repaint when using lod bias #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Fixed useless editor repaint when using lod bias #2601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0113945
Fixed useless editor repaint when using lod bias
adrien-de-tocqueville Nov 12, 2020
402ec79
Merge branch 'hd/bugfix' into hd/fix-lod-repaint
sebastienlagarde Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Fixed
- Fixed probe volumes debug views.
- Fixed issue displaying wrong debug mode in runtime debug menu UI.
- Fixed useless editor repaint when using lod bias.
- Fixed multi-editing with new light intensity slider.

## [10.2.0] - 2020-10-19

Expand Down Expand Up @@ -101,7 +103,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed picking for materials with depth offset.
- Fixed issue with exposure history being uninitialized on second frame.
- Fixed issue when changing FoV with the physical camera fold-out closed.
- Fixed multi-editing with new light intensity slider.

### Changed
- Combined occlusion meshes into one to reduce draw calls and state changes with XR single-pass.
Expand Down
9 changes: 9 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3332,8 +3332,13 @@ ref HDCullingResults cullingResults
var initialMaximumLODLevel = QualitySettings.maximumLODLevel;
try
{
#if UNITY_2021_1_OR_NEWER
// Modifying the variables this way does not set the dirty flag, which avoids repainting all views
QualitySettings.SetLODSettings(hdCamera.frameSettings.GetResolvedLODBias(hdrp), hdCamera.frameSettings.GetResolvedMaximumLODLevel(hdrp), false);
#else
QualitySettings.lodBias = hdCamera.frameSettings.GetResolvedLODBias(hdrp);
QualitySettings.maximumLODLevel = hdCamera.frameSettings.GetResolvedMaximumLODLevel(hdrp);
#endif

// This needs to be called before culling, otherwise in the case where users generate intermediate renderers, it can provoke crashes.
BeginCameraRendering(renderContext, camera);
Expand Down Expand Up @@ -3397,8 +3402,12 @@ ref HDCullingResults cullingResults
}
finally
{
#if UNITY_2021_1_OR_NEWER
QualitySettings.SetLODSettings(initialLODBias, initialMaximumLODLevel, false);
#else
QualitySettings.lodBias = initialLODBias;
QualitySettings.maximumLODLevel = initialMaximumLODLevel;
#endif
}
}

Expand Down