Temporarily hide Universal RP Point Light Shadows #2874
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T_SHADOWS until it is OK to expose them from a Product perspective
Wilfrid-Unity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
#1616 added to Universal RP the code needed to support Point Light Shadows.
#2126 will add to Universal RP the code needed to support Custom Shadow Resolutions.
It might be preferable for Unity users to start having access to both those features at the same time ; i.e from a product perspective, it might be preferable to start providing these two features in the same Unity release.
While the work for Point Light Shadows has been reviewed at length ; full approval for Custom Shadow Resolution is still pending.
This Pull Request can be used to defer the release of Point Light Shadows, if Unity Product Management teams deem it necessary to wait until Custom Shadow Resolutions are approved.
In case this Pull Request ends up getting merged, #2875 can be used to revert that action, and fully expose the Universal RP Point Light Shadows feature again ; once Unity Product Management teams have approved it.