[HDRP] Change the behavior of custom passes when the volume is disabled #2930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix this case: https://fogbugz.unity3d.com/f/cases/1300022/
To fix the domain reload issue, I changed the behavior of the custom pass volume:
Before the fix, disabling a custom pass volume, did not really impact the passes in the volume, they were just not executed.
Now with this fix, the function
Cleanup()
is called when theCustom Pass Volume
component is disabled, which allows releasing the resources allocated in the passes.Note that it shouldn't change the execution behavior of the passes.
Testing status
Tested that the Setup and Cleanup function of the custom passes are executed correctly when: