Skip to content

[HDRP] Change the behavior of custom passes when the volume is disabled #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2020
Merged

[HDRP] Change the behavior of custom passes when the volume is disabled #2930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c1c3a4
Changed the behavior of custom passes when the Custom Pass Volume com…
alelievr Dec 17, 2020
a152ab8
Updated changelog
alelievr Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- When in half res, RTR denoising is executed at half resolution and the upscale happens at the end.
- Removed the upscale radius from the RTR.
- Changed the message when the graphics device doesn't support ray tracing (case 1287355).
- When a Custom Pass Volume is disabled, the custom pass Cleanup() function is called, it allows to release resources when the volume isn't used anymore.

## [10.3.0] - 2020-12-01

Expand Down
3 changes: 1 addition & 2 deletions ...ipelines.high-definition/Runtime/RenderPipeline/RenderPass/CustomPass/CustomPassVolume.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,12 @@ void OnEnable()
void OnDisable()
{
UnRegister(this);
CleanupPasses();
#if UNITY_EDITOR
UnityEditor.SceneVisibilityManager.visibilityChanged -= UpdateCustomPassVolumeVisibility;
#endif
}

void OnDestroy() => CleanupPasses();

#if UNITY_EDITOR
void UpdateCustomPassVolumeVisibility()
{
Expand Down