Change Light Unit Slider Value Ranges #3195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienlagarde
approved these changes
Jan 20, 2021
iM0ve
approved these changes
Jan 20, 2021
iM0ve
approved these changes
Jan 20, 2021
sebastienlagarde
added
backported-10.x
needs-backport-2021.1
and removed
needs-backport-10.x
labels
sebastienlagarde
pushed a commit
that referenced
this pull request
Jan 21, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This is a small PR that nudges some light unit slider value ranges at the request of lighting artist.
It also fixes an issue where the Outdoor HDRP Scene template had a light configured for 130K Lux, and the slider's limit was 120K Lux, thus indicating caution to the user. The value range was extended so that the caution is no longer displayed:
Before:
After:
Also, the Exposure Sunlit Scene value range was changed from 12-16 EV to 12-15 EV, and the preset changed to 13 EV.
Testing status
I locally created a new scene with the outdoor HDRP template and confirmed that the new 130K value range no longer registers caution to the user. I also locally confirmed the changes to the Exposure Sunlit value range.
Comments to reviewers
~