Skip to content

Change Light Unit Slider Value Ranges #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Change Light Unit Slider Value Ranges #3195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f11063
Apply the range nudge
johnpars Jan 20, 2021
5f3d4c4
Changelog
johnpars Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Changed
- Change the source value for the ray tracing frame index iterator from m_FrameCount to the camera frame count (case 1301356).
- Change some light unit slider value ranges to better reflect the lighting scenario.

## [11.0.0] - 2020-10-21

Expand Down
4 changes: 2 additions & 2 deletions ...ity.render-pipelines.high-definition/Editor/Lighting/LightUnit/LightUnitSliderSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,15 @@ private static class LightUnitValueRanges

public static readonly LightUnitSliderUIRange[] LuxValueTable =
{
new LightUnitSliderUIRange(LightUnitIcon.BrightSky, LightUnitTooltips.k_LuxBrightSky, new Vector2(80000, 120000), 100000),
new LightUnitSliderUIRange(LightUnitIcon.BrightSky, LightUnitTooltips.k_LuxBrightSky, new Vector2(80000, 130000), 100000),
new LightUnitSliderUIRange(LightUnitIcon.Overcast, LightUnitTooltips.k_LuxOvercastSky, new Vector2(10000, 80000), 20000),
new LightUnitSliderUIRange(LightUnitIcon.SunriseSunset, LightUnitTooltips.k_LuxSunriseSunset, new Vector2(1, 10000), 5000),
new LightUnitSliderUIRange(LightUnitIcon.Moonlight, LightUnitTooltips.k_LuxMoonlight, new Vector2(0, 1), 0.5f),
};

public static readonly LightUnitSliderUIRange[] ExposureValueTable =
{
new LightUnitSliderUIRange(LightUnitIcon.BrightSky, LightUnitTooltips.k_ExposureBrightSky, new Vector2(12, 16)),
new LightUnitSliderUIRange(LightUnitIcon.BrightSky, LightUnitTooltips.k_ExposureBrightSky, new Vector2(12, 15), 13),
new LightUnitSliderUIRange(LightUnitIcon.Overcast, LightUnitTooltips.k_ExposureOvercastSky, new Vector2(8, 12)),
new LightUnitSliderUIRange(LightUnitIcon.SunriseSunset, LightUnitTooltips.k_ExposureSunriseSunset, new Vector2(6, 8)),
new LightUnitSliderUIRange(LightUnitIcon.InteriorLight, LightUnitTooltips.k_ExposureInterior, new Vector2(3, 6)),
Expand Down