rename occurrences of sample when used as a variable name #3216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename occurrences of sample when used as a shader variable name as this may be a reserved word in certain situatons
|
It appears that you made a non-draft PR! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sebastienlagarde
approved these changes
Jan 21, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Jan 21, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 3, 2021
rename occurrences of sample when used as a shader variable name as this may be a reserved word in certain situatons
sebastienlagarde
added a commit
that referenced
this pull request
Mar 3, 2021
* Fixed a regression introduced when changing the clamping algorithm for RTR and RTGI (case 1307479). (#3206) * rename occurrences of sample when used as a variable name (#3216) rename occurrences of sample when used as a shader variable name as this may be a reserved word in certain situatons * [HDRP] Update eye sample scene #3227 * Change the tooltip for color shadows and semi-transparent shadows (case 1307704). (#3237) * [Hdrp] Add 3DS max shader material test (#3239) * Arnold + Physical material * auto desk interactive * Reference image from yamato * linux vulkan test ref image * Hdrp/fix 1299233 ies resize #3243 * [HDRP] Fix metal warning + fix reference screenshots + disable unstable metal test #3251 * [HDRP] update some docs based on latest changelog (#3253) * Update some docs * Proof read upgrading to 2020.2 * Proof read whats new doc * Fixed typo Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: peterjohnlong <73894199+peterjohnlong@users.noreply.github.com> Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR renames some shader variable names where "sample" had been used as the name. "sample" is a reserved word on some platforms and thus would cause a compile error if those shaders were to be compiled there.
Testing status
Tested locally that HDRP-DXR test shaders still compile successfully in DX12.
Tested locally that the affected platform branch, with raytrace shader compile enabled, can now successfully compile and run the HDRP template.
Comments to reviewers
Notes for the reviewers you have assigned.