Added the default quality settings to the HDRP asset for RTAO, RTR and RTGI (case 1304370). #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d RTGI (case 1304370).
remi-chapelain
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
Tried to change the settings to see if it applies correctly when changing quality settings ✔️
Modified a bit the labels and order to be consistent between settings and actual naming on the overrides.
I'll report this later but I thought of 2 things
-
RTAO has its SSAO quality setting fallback,
RTR has its SSR quality setting fallback,
RTGI has NOT its quality setting fallback whereas there's some quality settings in SSGI.
Reported here.
-
[FIXED]
We should indent everything in the quality setting in between low/med/high, for it to be clearer and easier to read
To match PR comment and what is done with DoF Quality settings
|
Fixed the second point (2.) mentioned in the previous comment in the last commit. |
sebastienlagarde
approved these changes
Feb 5, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 3, 2021
…d RTGI (case 1304370). #3362
sebastienlagarde
added a commit
that referenced
this pull request
Mar 3, 2021
* Merge Hd/bugfix #3313 * Fix frame count in editor #3173 * Fixed the display name of a Volume Parameter when is defined the attribute InspectorName #3348 * Added the default quality settings to the HDRP asset for RTAO, RTR and RTGI (case 1304370). #3362 * Formatting * Windows vulkan reference screenshots Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fogbugz.unity3d.com/f/cases/1304370/
Testing status
Checked that the new submenus display correctly.