[2022.1] Universal: Fixing 146 MSAA test scene. #3570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuele-bonanno
approved these changes
Feb 19, 2021
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
ellioman
changed the title
phi-lira
pushed a commit
that referenced
this pull request
Oct 12, 2021
* Fixing 146 MSAA test. * Revert "Fixing 146 MSAA test." This reverts commit a0c849e. * Fixing MSAA test scene * Minor cleanup of RP Assets. * Reverting a change in GraphicsSettings and QualitySettings * Materials * Reverting a change in QualitySettings * Increasing the test threshold from 0 to 0.0025 * Lowering the threshold to 0.001 * Updating Reference Images for DX11 and DX12
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Previously when I modified this test scene in #2802, I broke the backbuffer part of the test.
This PR fixes that to make sure we are testing BackBuffer MSAA properly.