[HDRP] Fix volume component nullref #3644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix case https://fogbugz.unity3d.com/f/cases/1317156/
Apparently, the
AssetDatabase.SaveAssets()
function caused the serializedObject of the volume to be invalid and thus all its serialized properties were broken when we tried to access them to create the volume editor. Moving theSaveAssets
just after the creation of the volume editor seems to fix the issue.Testing status
Tested adding and removing components on a Volume profile from a GameObject in the scene, from an asset on the disk and a preset on the disk. Everything looks correct.
Comments to reviewers
@Chman Do you know why the AssetDatabase Save was made between the code that gets the new serialized property for the volume and the editor creation?